Fix token expired race and improve panic messages#334
Merged
tolik518 merged 4 commits intotolik518:masterfrom Mar 7, 2026
Merged
Fix token expired race and improve panic messages#334tolik518 merged 4 commits intotolik518:masterfrom
tolik518 merged 4 commits intotolik518:masterfrom
Conversation
move from expect("...") to unwrap_or_else(|| panic!("...")) including more context in the message
Aras14HD
force-pushed
the
fix-token_expired-race
branch
from
51bcf8a to
75d6ee6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aims to fix crashes due to non-json responses, likely due to expired tokens.
In addition, as we would have been able to be more sure about the issue, if we had more context in the errors, this improves these. For that it replaces
.expect("...")with.unwrap_or_else(|err| panic!("...: {err} in {response_text})).It also does similar for most expects (pretty much where possible).
Resolves #270